Skip to content

Conversation

@roncohen
Copy link
Contributor

@roncohen roncohen commented Mar 5, 2025

  • Deprecate enabledCheck and configCheck event listeners in favour of just check.
  • Publishes new patch version for browser and react sdks.

@roncohen roncohen requested a review from laander March 5, 2025 18:38
@roncohen roncohen enabled auto-merge (squash) March 5, 2025 18:49
Copy link
Contributor

@laander laander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

we should document the CheckEvent properties somewhere accessible as you need to know that action can be used as a discriminator:

CheckEvent = {
      action: "check-is-enabled",
      key: "test-key",
      value: true,
    };

does this automatically get surfaced on docs.bucket.co when docs are auto-built? we could also just JSDoc clause with a short description

@roncohen
Copy link
Contributor Author

roncohen commented Mar 6, 2025

we should document the CheckEvent properties somewhere accessible as you need to know that action can be used as a discriminator

agreed. And yeah, we do automatic reference docs now, but those can also be improved. I'll get this in now and look at improving the docs separately.

@roncohen roncohen merged commit 10eae84 into main Mar 6, 2025
5 checks passed
@roncohen roncohen deleted the rename-enabledcheck branch March 6, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants