Skip to content

feat: improve logging by fetching bootstrap first#374

Merged
Swiftwork merged 6 commits intomainfrom
feat/cli-improve-logging
Mar 13, 2025
Merged

feat: improve logging by fetching bootstrap first#374
Swiftwork merged 6 commits intomainfrom
feat/cli-improve-logging

Conversation

@Swiftwork
Copy link
Contributor

By adding a call to bootstrap we can improve the logging of the CLI.

Kapture.2025-03-13.at.13.00.35.mp4

@Swiftwork Swiftwork added the enhancement New feature or request label Mar 13, 2025
@Swiftwork Swiftwork requested a review from roncohen March 13, 2025 12:02
@Swiftwork Swiftwork self-assigned this Mar 13, 2025
Copy link
Contributor

@roncohen roncohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally i think it's great to have improved logging 👍 A little worried about the bootstrap call what we'll incur on every invocation in terms of just making the CLI feel snappy, but it's probably fine.

One general comment: I don't think we need to log out request by default. In the video it logs "Loaded apps from ...". Thats probably unnecessary.

Btw. if you always pull the apps, we don't need to store the featureKeyFormat anymore since that's available in the bootstrap. Interestingly, it's at the Org level. I would have expected it to be at the app level, but it'll have to do for now.

@Swiftwork
Copy link
Contributor Author

Swiftwork commented Mar 13, 2025

Based on your feedback I rewrote the code in 52e77da to load feature key and to write out the entire URL to the new feature as we now have the environments loaded.

image

@roncohen
Copy link
Contributor

cool! lets get it int!

@Swiftwork Swiftwork enabled auto-merge (squash) March 13, 2025 14:39
@Swiftwork Swiftwork merged commit abfa0f6 into main Mar 13, 2025
5 checks passed
@Swiftwork Swiftwork deleted the feat/cli-improve-logging branch March 13, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants