feat: use new login scheme which supports Safari#375
Merged
Conversation
Swiftwork
approved these changes
Mar 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This authentication flow does not use a fetch request to
http://localhostbut instead redirects there. We don't want to pass the actual access token along so it becomes part of the browser history. Instead we supple a code which is then exchanged for the actual access token through a new API endpoint in the backend.This starts to look very much like a standard oauth flow. The key missing piece is come
client_idparameters. I'm making the new server endpoints live under/api/oauth/cliso that when we do introduce propert oauth there will be no clashes.I removed the spinner on login because it indicates that it's working when in reality it's waiting for you to do something. I'm also printing out the URL in case opening of the browser doesn't work.