Skip to content

fix(flag-evaluation): use js-sha256 which can fall back to pure js#390

Merged
roncohen merged 4 commits intomainfrom
fallback-js-sha256
Mar 28, 2025
Merged

fix(flag-evaluation): use js-sha256 which can fall back to pure js#390
roncohen merged 4 commits intomainfrom
fallback-js-sha256

Conversation

@roncohen
Copy link
Contributor

@roncohen roncohen commented Mar 28, 2025

This solution should fall back to a pure JS based solution is "crypto" isn't available and doesn't require us to change the public interface of the package from sync to async.

@roncohen roncohen requested a review from pavkam March 28, 2025 13:35
@roncohen roncohen changed the title fix: use js-sha256 which can fall back to pure js fix(flag-evaluation): use js-sha256 which can fall back to pure js Mar 28, 2025
@roncohen roncohen added this pull request to the merge queue Mar 28, 2025
Merged via the queue into main with commit 912f017 Mar 28, 2025
5 checks passed
@roncohen roncohen deleted the fallback-js-sha256 branch March 28, 2025 14:11
github-merge-queue bot pushed a commit that referenced this pull request Mar 28, 2025
…to (#391)

This is required to make the NodeSDK work on edge runtimes. Needs #390
to go in first.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants