Skip to content

chore: move react specific eslint configs into react-sdk#421

Merged
roncohen merged 1 commit intomainfrom
react-eslint
Jun 19, 2025
Merged

chore: move react specific eslint configs into react-sdk#421
roncohen merged 1 commit intomainfrom
react-eslint

Conversation

@roncohen
Copy link
Contributor

In preparation for adding a Vue.js SDK, we need the React specific lints to only run when needed.

Also fixed a couple of lints uncovered

@roncohen roncohen requested a review from Copilot June 18, 2025 09:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

In preparation for a future Vue SDK, React-specific ESLint rules and plugins have been extracted into the react‐sdk package so they only apply to React files; the base config was cleaned up, and a Preact config plus lint fixes were added to the browser SDK.

  • Moved React & React Hooks rules/plugins from the shared base into packages/react-sdk/eslint.config.js scoped to *.ts/*.tsx.
  • Removed React-related settings from packages/eslint-config/base.js and added the missing globals dependency.
  • Added eslint-config-preact and adjusted lint configs in the browser SDK; fixed some lint errors in UI components (type rename, template literals).

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/react-sdk/eslint.config.js New override with React & Hooks rules/plugins scoped to ts/tsx
packages/eslint-config/package.json Added globals dependency
packages/eslint-config/base.js Removed React/Hooks rules and plugins from base config
packages/browser-sdk/src/feedback/ui/StarRating.tsx Renamed the Score type alias to ScoreNumber to avoid a conflict
packages/browser-sdk/src/feedback/ui/FeedbackForm.tsx Switched string concatenations to template literals for maxHeight
packages/browser-sdk/package.json Added eslint-config-preact dependency
packages/browser-sdk/eslint.config.js Introduced Preact-specific ESLint config and rule adjustments

fix various lints that were uncovered
@roncohen roncohen added this pull request to the merge queue Jun 19, 2025
Merged via the queue into main with commit b4cb47c Jun 19, 2025
6 checks passed
@roncohen roncohen deleted the react-eslint branch June 19, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants