chore: move react specific eslint configs into react-sdk#421
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
In preparation for a future Vue SDK, React-specific ESLint rules and plugins have been extracted into the react‐sdk package so they only apply to React files; the base config was cleaned up, and a Preact config plus lint fixes were added to the browser SDK.
- Moved React & React Hooks rules/plugins from the shared base into
packages/react-sdk/eslint.config.jsscoped to*.ts/*.tsx. - Removed React-related settings from
packages/eslint-config/base.jsand added the missingglobalsdependency. - Added
eslint-config-preactand adjusted lint configs in the browser SDK; fixed some lint errors in UI components (type rename, template literals).
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/react-sdk/eslint.config.js | New override with React & Hooks rules/plugins scoped to ts/tsx |
| packages/eslint-config/package.json | Added globals dependency |
| packages/eslint-config/base.js | Removed React/Hooks rules and plugins from base config |
| packages/browser-sdk/src/feedback/ui/StarRating.tsx | Renamed the Score type alias to ScoreNumber to avoid a conflict |
| packages/browser-sdk/src/feedback/ui/FeedbackForm.tsx | Switched string concatenations to template literals for maxHeight |
| packages/browser-sdk/package.json | Added eslint-config-preact dependency |
| packages/browser-sdk/eslint.config.js | Introduced Preact-specific ESLint config and rule adjustments |
fix various lints that were uncovered
Swiftwork
approved these changes
Jun 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation for adding a Vue.js SDK, we need the React specific lints to only run when needed.
Also fixed a couple of lints uncovered