docs(vue-sdk): simplify getting started docs#433
Merged
Conversation
Contributor
roncohen
commented
Jun 20, 2025
- Simplify getting started example
- Remove fallback features as they only serve to make folks confused and they are not really being used.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the getting started guide in the Vue SDK README by removing the feedback fallback features and example, and adds a pointer to reference docs.
- Removes the "Give feedback!" button and its wrapping
<div>closing tag - Deletes the
fallbackFeaturessection and its example block - Adds a generic pointer to the reference docs
Comments suppressed due to low confidence (3)
packages/vue-sdk/README.md:113
- [nitpick] Trailing comma remains after this sentence now that the following bullet was removed. It should end with a period.
> If you specify `company` and/or `user` they must have at least the `id` property, otherwise they will be ignored in their entirety. You should also supply anything additional you want to be able to evaluate feature targeting against,
packages/vue-sdk/README.md:185
- [nitpick] Consider adding a direct link or path to the reference documentation so readers can navigate immediately to the detailed API descriptions.
See the reference docs for details.
packages/vue-sdk/README.md:49
- The closing
</div>tag for the<div v-if="huddle.isEnabled">block was removed. This will break the template—re-add</div>before</template>.
</template>
matus-vacula
approved these changes
Jun 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.