Skip to content

docs(vue-sdk): simplify getting started docs#433

Merged
roncohen merged 4 commits intomainfrom
vue-docs-improve
Jun 23, 2025
Merged

docs(vue-sdk): simplify getting started docs#433
roncohen merged 4 commits intomainfrom
vue-docs-improve

Conversation

@roncohen
Copy link
Contributor

  • Simplify getting started example
  • Remove fallback features as they only serve to make folks confused and they are not really being used.

@roncohen roncohen requested review from Copilot and matus-vacula June 20, 2025 06:51
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR simplifies the getting started guide in the Vue SDK README by removing the feedback fallback features and example, and adds a pointer to reference docs.

  • Removes the "Give feedback!" button and its wrapping <div> closing tag
  • Deletes the fallbackFeatures section and its example block
  • Adds a generic pointer to the reference docs
Comments suppressed due to low confidence (3)

packages/vue-sdk/README.md:113

  • [nitpick] Trailing comma remains after this sentence now that the following bullet was removed. It should end with a period.
  > If you specify `company` and/or `user` they must have at least the `id` property, otherwise they will be ignored in their entirety. You should also supply anything additional you want to be able to evaluate feature targeting against,

packages/vue-sdk/README.md:185

  • [nitpick] Consider adding a direct link or path to the reference documentation so readers can navigate immediately to the detailed API descriptions.
See the reference docs for details.

packages/vue-sdk/README.md:49

  • The closing </div> tag for the <div v-if="huddle.isEnabled"> block was removed. This will break the template—re-add </div> before </template>.
</template>

@roncohen roncohen enabled auto-merge June 23, 2025 09:43
@roncohen roncohen added this pull request to the merge queue Jun 23, 2025
Merged via the queue into main with commit 559c040 Jun 23, 2025
6 checks passed
@roncohen roncohen deleted the vue-docs-improve branch June 23, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants