Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds Cloudflare Worker support to the Node SDK by introducing an edge-optimized cache strategy, updating the client to select between cache strategies, and providing example configurations and documentation.
- Introduce
inRequestCacheand rename the existing cache toperiodicallyUpdatingCache - Add
EdgeClientclass with"in-request"cache strategy and updateBucketClientto choose based oncacheStrategy - Supply Cloudflare Worker examples, configuration files, and update documentation
Reviewed Changes
Copilot reviewed 25 out of 35 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/node-sdk/src/periodicallyUpdatingCache.ts | Rename default cache export and add stubbed waitRefresh |
| packages/node-sdk/src/inRequestCache.ts | Add serverless-friendly request-scoped cache implementation |
| packages/node-sdk/src/edgeClient.ts | New EdgeClient class preconfigured for edge runtimes |
| packages/node-sdk/src/client.ts | Wire up cacheStrategy, branch cache instantiation, add waitRefresh to flush |
| packages/node-sdk/src/types.ts | Introduce CacheStrategy and waitRefresh in Cache<T> type |
| packages/node-sdk/test/inRequestCache.test.ts | New tests for inRequestCache |
| packages/node-sdk/README.md | Document Cloudflare Worker usage and links to examples |
pavkam
approved these changes
Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds Cloudflare Worker support to the Node SDK by introducing an edge-optimized cache strategy, updating the client to select between cache strategies, and providing example configurations and documentation.