feat(node-sdk): use optimized flag evaluation#442
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR integrates the new optimized flag evaluation facility from the flag-evaluation package to improve CPU efficiency when handling large target lists. Key changes include:
- Removing evaluateFeatureRules mocks and expectations in the test suite.
- Adding a new CachedFeatureDefinition type and integrating newEvaluator in types and client modules.
- Updating client logic to use newEvaluator for both enabled and config evaluations.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/node-sdk/test/client.test.ts | Removed redundant evaluateFeatureRules mocks and adjusted test expectations. |
| packages/node-sdk/src/types.ts | Introduced CachedFeatureDefinition and imported newEvaluator to support evaluations. |
| packages/node-sdk/src/client.ts | Updated feature evaluation flow to compute evaluation results using newEvaluator and adjusted cache type accordingly. |
pavkam
approved these changes
Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the new facility from the
flag-evaluationpackage to ensure low CPU even with huge lists of targets.