feat: added offline mode to aid in testing#444
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds an optional offline mode to the browser SDK to enable testing scenarios where server communication is not required. The offline mode prevents all HTTP requests while maintaining the same API surface.
- Added
offlineconfiguration option to client initialization - Modified core methods to skip HTTP calls when offline mode is enabled
- Added comprehensive test coverage for offline functionality
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/browser-sdk/src/client.ts | Added offline configuration option and early returns in HTTP-dependent methods |
| packages/browser-sdk/src/feature/features.ts | Added offline support to features client to prevent feature fetching |
| packages/browser-sdk/test/client.test.ts | Added test coverage for offline mode functionality |
Comments suppressed due to low confidence (1)
Swiftwork
reviewed
Jul 16, 2025
Contributor
Swiftwork
left a comment
Swiftwork
left a comment
There was a problem hiding this comment.
Looks harmless but does this not need a package version bump? And has this been discussed?
roncohen
approved these changes
Jul 16, 2025
Contributor
roncohen
left a comment
roncohen
left a comment
There was a problem hiding this comment.
Might be useful with some docs too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an optional
offlinemode to the browser SDK to aid with testing where contacting the servers is not needed.