Skip to content

feat: treat "null" strings as null#457

Closed
Swiftwork wants to merge 2 commits intomainfrom
buc-1877-null-value-attributes-are-not-matched-by-the-has-no-value
Closed

feat: treat "null" strings as null#457
Swiftwork wants to merge 2 commits intomainfrom
buc-1877-null-value-attributes-are-not-matched-by-the-has-no-value

Conversation

@Swiftwork
Copy link
Contributor

@Swiftwork Swiftwork requested review from Copilot and pavkam August 12, 2025 12:15
@Swiftwork Swiftwork self-assigned this Aug 12, 2025
@Swiftwork Swiftwork added the enhancement New feature or request label Aug 12, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the flag evaluation logic to treat the string "null" as equivalent to an actual null value in SET and NOT_SET operations. The change is implemented in the flag-evaluation package and propagated through version bumps across dependent packages.

  • Modified SET and NOT_SET operations to handle "null" strings as null values
  • Bumped package versions to reflect the changes across the dependency chain

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.

File Description
packages/flag-evaluation/src/index.ts Updated SET/NOT_SET logic to treat "null" strings as null values
packages/flag-evaluation/package.json Version bump to 0.2.2
packages/node-sdk/package.json Version bump to 1.9.4 and dependency update
packages/openfeature-node-provider/package.json Dependency update to use new node-sdk version

@Swiftwork Swiftwork closed this Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant