Skip to content

fix: make stop propagated event listeners passive#458

Merged
Swiftwork merged 2 commits intomainfrom
buc-3942-implement-passive-scroll-events-in-browser-sdk
Aug 13, 2025
Merged

fix: make stop propagated event listeners passive#458
Swiftwork merged 2 commits intomainfrom
buc-3942-implement-passive-scroll-events-in-browser-sdk

Conversation

@Swiftwork
Copy link
Contributor

No description provided.

@Swiftwork Swiftwork requested review from Copilot and pavkam August 13, 2025 09:05
@Swiftwork Swiftwork self-assigned this Aug 13, 2025
@Swiftwork Swiftwork added bug Something isn't working enhancement New feature or request labels Aug 13, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Contributor

@pavkam pavkam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but I'll trust you know what you are doing :)

@Swiftwork
Copy link
Contributor Author

Looks fine, but I'll trust you know what you are doing :)

Did some tests and passive does not impact stopPropgation. Which is the only purpose of these code paths.

@Swiftwork Swiftwork added this pull request to the merge queue Aug 13, 2025
Merged via the queue into main with commit b511473 Aug 13, 2025
6 checks passed
@Swiftwork Swiftwork deleted the buc-3942-implement-passive-scroll-events-in-browser-sdk branch August 13, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants