Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Fixes error handling for version check functionality to prevent process failures when the version check is blocked or fails. The change replaces the try-catch error handling approach with promise rejection handling using .catch().
- Modified
getLatestVersionFromNpmto throw an error immediately (temporarily for testing) - Updated
checkLatestto handle promise rejections gracefully with.catch() - Removed try-catch block around version check in main CLI function
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/cli/utils/version.ts | Commented out npm fetch logic and added error handling via .catch() |
| packages/cli/index.ts | Removed try-catch wrapper around version check promise |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
pavkam
reviewed
Sep 17, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
pavkam
approved these changes
Sep 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the version check is blocked for some reason, the process can fail. Apparently promise rejections can happen without
awaitcalls.