Issue #478: Replace client side LOG messages by INFO#479
Merged
Conversation
Client code shouldn't log LOG level messages since it is considered as a server operational messages according to PostgreSQL logic. The function `log_required()`, which is used by pg_repack, is basically copy of a similar function from PostgreSQL code, therefore we should follow same logic.
Melkij
approved these changes
Feb 13, 2026
andreasscherbaum
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Client code shouldn't log
LOGlevel messages since it is considered as a server operational messages according to PostgreSQL logic. The functionlog_required()[1], which is used by pg_repack, is basically copy of a similar function [2] from PostgreSQL code, therefore we should follow same logic.Issue #478