Replace rustls-pemfile with rustls-pki-types, fix msrv and update msrv / edition#105
Closed
threema-donat wants to merge 10 commits intoreown-com:masterfrom
Closed
Replace rustls-pemfile with rustls-pki-types, fix msrv and update msrv / edition#105threema-donat wants to merge 10 commits intoreown-com:masterfrom
threema-donat wants to merge 10 commits intoreown-com:masterfrom
Conversation
Since the library is not updated very often, it is more ergonomic to have no lockfile but only a msrv. This allows for updates of the dependencies without having to release.
hyper-rustls 0.26.0 requires rusctc 1.82.0 due to the dependency on indexmap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This MR fixes the MSRV, removes the lockfile from version control and replaces the unmaintained
rustls-pemfilewith the suggested alternativerustls-pki-types. Furthermore, it updates the edition to2024.The MSRV is currently incorrect in master, since
hyper-rustls 0.26.0depends onindexmap, which requires1.82.0to build.The motivation behind removing the lockfile is that the dependents can define the versions of the dependencies themselves to be up-to-date since this crate is not updated very often.
Resolves issues #99 and makes #102 obsolete
How Has This Been Tested?
This has been tested locally with a binary that sends APNS pushes. It has been tested only with the sandbox of APNS.
Due Dilligence