Provide libsodium with the correct buffer size.#52
Open
bbockelm wants to merge 1 commit intorescrv:releases/0.3from
Open
Provide libsodium with the correct buffer size.#52bbockelm wants to merge 1 commit intorescrv:releases/0.3from
bbockelm wants to merge 1 commit intorescrv:releases/0.3from
Conversation
bin2hex in libsodium appends a null-character to the output array, meaning the hex array must be 2 * (sizeof bin array) + 1 characters long. Within libmacaroons, that appears to be the actual buffer size -- but we were passing this incorrectly to libsodium. In newer versions of libsodium, this triggers an internal assert.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bin2hexin libsodium appends a null-character to the output array, meaning the hex array must be2 * (sizeof bin array) + 1characters long.Within libmacaroons, that appears to be the actual buffer size -- but we were passing this incorrectly to libsodium. In newer versions of libsodium, this triggers an internal assert.