Open
Conversation
Also, correct typo in `set_state_listener` method.
This is consistent with the examples for setting up AVS samples, for example https://github.com/alexa/alexa-avs-sample-app/wiki/Create-Security-Profile
Contributor
|
The hardcoded ReSpeaker client ID is a feature for these who just want to try Alexa as quick as possible. |
Contributor
Author
OK, makes sense. Could I suggest one of the following:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While getting familiar with the code, I found a number of small issues:
avs/main.pyfor using hotwords, and inavs/check.py, but not inavs/alexa.py.config.json, they'll end up authorising your account by accident.