Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear team,
The main functionalities of this assignment has not been finished yet.
The app should works on web, Android and iOS - done.
Orders list has not been shown correctly - failed
Orders could not be marked as picked up yet - failed
Orders can be filtered by open/closed/all orders but not yet been shown correctly - failed.
My idea on the way this screen fetch the very long list of orders:
Currently the UI retrieve the whole list of orders, and update the list whenever there is any change with an update full new list. The payload of this process would be large and it would be inefficient.
I suggest to break the fetching process into 2 steps:
Load the list contains only customers' information, total, status,...
Only load the detail list of orders of each customer when UI need to render that list to show more details
Following this flow, the payload of every request will be broken down into specific details that the UI needs. This will improve UI in case of long list of customers and orders need to be loaded/updated.
My bad that I have not implemented this idea yet. Hope that this would contribute to the project.