Skip to content

Conversation

@adamchol
Copy link
Contributor

@adamchol adamchol commented Jan 29, 2026

Small simplification which makes rejecting calls return unit instead of Result<()>.

I noticed that DialogInner::transition() doesn't actually return Err(_) ever, so I just changed the return type to unit.

There might be more cases like that in the codebase.

@yeoleobun
Copy link
Collaborator

yeoleobun commented Jan 29, 2026

Yes, there are lot of things like this. Some are pattern, some inner Error are removed or just logged.
But if it is not a bug, like some Error should report, but actually not returned from inner, we intend to clean it up for a major version.

@yeoleobun yeoleobun closed this Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants