Skip to content

JavaScript: Fix category filtration bug and update Node version requirements #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gitname wants to merge 2 commits into
base: main
Choose a base branch
from
Open

JavaScript: Fix category filtration bug and update Node version requirements #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5e0a34
Update Node version requirements to exclude v17+
gitname Feb 8, 2023
d2d27bc
Interpret query as literal string instead of as regular expression
gitname Feb 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion web_full_stack/js/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ JavaScript Code Extension
The JS Code Extension is a React application created using [create-react-app](https://github.com/facebook/create-react-app). Tests are written using [enzyme](https://github.com/airbnb/enzyme) and [react-router](https://github.com/ReactTraining/react-router) manages routing.

# Setup
You'll need [yarn](https://yarnpkg.com/en/) installed and a recent version (>= 10) of [Node](https://nodejs.org/en/) to use this project. If you're using homebrew you can brew install both of those or if you want to manage multiple versions of node on your machine, we suggest using a tool like [nodenv](https://github.com/nodenv/nodenv).
You'll need [yarn](https://yarnpkg.com/en/) installed and a version of [Node](https://nodejs.org/en/) between v10 and v16, inclusive, to use this project. If you're using homebrew you can brew install both of those or if you want to manage multiple versions of node on your machine, we suggest using a tool like [nodenv](https://github.com/nodenv/nodenv).

* `yarn install` to install dependencies.

Expand Down
2 changes: 1 addition & 1 deletion web_full_stack/js/src/CategoriesPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ function filteredCategories(categories, query) {
if (!query) { return categories };

return categories.filter((category) => {
return category.full_name.match(new RegExp(query, 'i'));
return category.full_name.toLowerCase().includes(query.toLowerCase());
});
}

Expand Down