Skip to content

[CRE-1055] fix: Limited photo permissions#78

Merged
chenium merged 2 commits intomasterfrom
CRE-1055-limited-photo-fixes
Dec 30, 2025
Merged

[CRE-1055] fix: Limited photo permissions#78
chenium merged 2 commits intomasterfrom
CRE-1055-limited-photo-fixes

Conversation

@ahavamorse
Copy link

This PR fixes a couple issues:

  • Loading indicator stops when there is no media to load
  • Calls libraryViewHaveNoItems when photo permissions is denied

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes handling of limited photo permissions by ensuring proper UI feedback and delegate notifications when the photo library is empty or access is denied.

  • Adds a permission denied callback to handle cases where photo permissions are restricted
  • Stops the loading indicator when there are no media items to load
  • Makes protocol visibility public to enable proper delegate communication

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
Source/YPPickerVC.swift Makes YPPickerVCDelegate protocol and delegate property public; adds permissionDeniedBlock to trigger libraryViewHaveNoItems when permissions are denied
Source/YPImagePicker.swift Makes protocol conformance methods public to match public protocol
Source/Pages/Gallery/YPLibraryVC.swift Extracts libraryViewHaveNoItems into helper method that hides loader before calling delegate
Source/Helpers/Permissions/YPPermissionCheckable.swift Adds optional permissionDeniedBlock parameter to handle permission denial cases

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chenium chenium merged commit 4961331 into master Dec 30, 2025
9 of 10 checks passed
@chenium chenium deleted the CRE-1055-limited-photo-fixes branch December 30, 2025 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants