[CRE-1055] fix: Limited photo permissions#78
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes handling of limited photo permissions by ensuring proper UI feedback and delegate notifications when the photo library is empty or access is denied.
- Adds a permission denied callback to handle cases where photo permissions are restricted
- Stops the loading indicator when there are no media items to load
- Makes protocol visibility public to enable proper delegate communication
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Source/YPPickerVC.swift | Makes YPPickerVCDelegate protocol and delegate property public; adds permissionDeniedBlock to trigger libraryViewHaveNoItems when permissions are denied |
| Source/YPImagePicker.swift | Makes protocol conformance methods public to match public protocol |
| Source/Pages/Gallery/YPLibraryVC.swift | Extracts libraryViewHaveNoItems into helper method that hides loader before calling delegate |
| Source/Helpers/Permissions/YPPermissionCheckable.swift | Adds optional permissionDeniedBlock parameter to handle permission denial cases |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
iirovi-rs
approved these changes
Dec 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a couple issues:
libraryViewHaveNoItemswhen photo permissions is denied