-
Notifications
You must be signed in to change notification settings - Fork 0
Initial Release of Cerberus #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Initial release of Cerberus, a serverless AWS solution to monitor and remove Control Tower default permission‐set assignments.
- Added infrastructure templates (SAM, EventBridge rule)
- Implemented core Lambda logic and Step Functions state machine
- Included unit tests, documentation, and CI configuration
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| cft-eventbridge-rule.yaml | CloudFormation template for forwarding SSO events |
| cerberus/tests/unit/test_cerberus.py | Unit tests for the Lambda handler |
| cerberus/tests/requirements.txt | Added boto3 dependency for tests |
| cerberus/template.yaml | SAM template defining state machine, Lambda, events |
| cerberus/statemachine/cerberus.asl.json | Step Functions ASL for processing events |
| cerberus/src/cerberus/app.py | Lambda function logic for deleting assignments |
| cerberus/samconfig.toml | SAM CLI configuration |
| cerberus/README.md | Detailed build, deploy, and usage documentation |
| SECURITY.md | Project security policy |
| README.md | Project overview and quickstart |
| .github/workflows/lint.yml | GitHub Actions workflow for linting |
Comments suppressed due to low confidence (2)
cerberus/src/cerberus/app.py:120
- The real API response from delete_account_assignment is being overwritten with a static success dict—remove or adjust this line so that the actual AWS response is used.
response = {"AccountAssignmentDeletionStatus": {"Status": "SUCCEEDED"}}
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
jason-meredith-rewind
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wicked name 🔥
Pull Request: Initial Release of Cerberus
Description
This pull request introduces the initial release of Cerberus, an open-source project designed to manage and remove AWS Control Tower default permission set associations. Cerberus leverages the AWS Serverless Application Model (SAM) to provide a scalable, serverless solution for monitoring and managing IAM Identity Center events.
Key Features
cerberus.asl.jsonto processCreateAccountAssignmentevents.app.py) to handle the removal of unauthorized permission sets.template.yaml: Defines the serverless resources, including the state machine, Lambda function, EventBridge rules, and supporting infrastructure.cft-eventbridge-rule.yaml: A CloudFormation template for setting up EventBridge rules.test_cerberus.py) to ensure the correctness of the Lambda function logic.README.md: Overview of the project, deployment instructions, and contribution guidelines.cerberus/README.md: Detailed instructions for building, deploying, and testing the application.Key Files
src/cerberus/app.py: Core Lambda function logic.statemachine/cerberus.asl.json: State machine definition.template.yaml: SAM template for deploying the application.cft-eventbridge-rule.yaml: CloudFormation template for EventBridge rules.tests/unit/test_cerberus.py: Unit tests for the Lambda function.tests/requirements.txt: Dependencies for running tests.lint.yml: GitHub Actions workflow for linting withblack.code-scanning.yml: GitHub Actions workflow for CodeQL analysis.