feat(observability): Wire Observer into gateway runtime#87
Merged
Conversation
Integrates the Observer trait into the gateway's request lifecycle: - Add SharedObserver type alias and optional parameter to run_gateway - Thread observer through handle_connection → dispatch_text_message - Record LlmRequest event before provider calls (provider, model, message count) - Record LlmResponse event after (duration, success, error message) - Record ToolCallStart before each tool execution - Record ToolCall after (duration, success) Call sites pass None for now; actual observer backends can be wired in by passing Arc<LogObserver> or CompositeObserver at startup.
Owner
Author
|
LGTM! Clean integration:
One future enhancement: consider adding Ship it! 🚢 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrates the Observer trait into the gateway's request lifecycle.
Changes
SharedObservertype alias and optional parameter torun_gatewayhandle_connection→dispatch_text_messageUsage
Call sites currently pass
Nonefor the observer. To enable observability:Next Steps
LogObserverby default when a config flag is setObserverMetricrecording (latencies, queue depth)