Open
Conversation
rhaarm
commented
May 21, 2018
benchmark/benchmark.py
Outdated
|
|
||
| def validate_many(records, schema): | ||
| return all([validate(record, schema) for record in records]) | ||
| from fastavro.validate import validate, validate_many |
Owner
Author
There was a problem hiding this comment.
This should be updated as well for the name change of validate to validation
rhaarm
commented
May 22, 2018
Owner
Author
rhaarm
left a comment
rhaarm
left a comment
There was a problem hiding this comment.
all looks good, except I have concern about the validate_many, it had a "stop_count" that was removed, which is beneficial when wanting to exit early or continue thru all records and only raise the invalid ones.
|
|
||
|
|
||
| cpdef validate_many(records, schema, bint raise_errors=False, int stop_count=-1): | ||
| cpdef validate_many(records, schema, bint raise_errors=True): |
Owner
Author
There was a problem hiding this comment.
Why was stop_count removed? If validating many items and you wanted to exit on the first error, this would allow for early exit. Or if you wanted to capture all errors or just a few, it allows for that situation. Thoughts?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scott's changes on Validators feature.