Skip to content

Comments

fix error of non-found smach_tutorials.msg#3

Open
LongfeiProjects wants to merge 1 commit intorhaschke:indigo-develfrom
Kinova-Movo:indigo-devel
Open

fix error of non-found smach_tutorials.msg#3
LongfeiProjects wants to merge 1 commit intorhaschke:indigo-develfrom
Kinova-Movo:indigo-devel

Conversation

@LongfeiProjects
Copy link

import smach_tutorials.msg would cause an error. A quick fix applied to eliminate this error.

@130s
Copy link

130s commented May 15, 2018

@LongfeiProjects FYI I'm suggesting to move executive_smach_tutorials to ros organization in ros/common_tutorials#19

@rhaschke
Copy link
Owner

I don't see which kind of error you get. In any case, the fix doesn't make sense to me. You load the msg of a completely different package now...
Also note, that this repo is a private fork and I'm not the maintainer of this package. I'm not sure who is...

@LongfeiProjects
Copy link
Author

I found the following error while I run both actionlib examples (actionlib_test.py and actionlib2_test.py) under folder executive_smach_tutorials/examples. The error messages are below:

Traceback (most recent call last):
File "./actionlib_test.py", line 25, in
from smach_tutorials.msg import TestAction, TestGoal
ImportError: No module named smach_tutorials.msg

When I check further about this problem, I didn't found that "smach_tutorials.msg" in this tutorial repository. Therefore, this error make sense. However, I found "TestAction" and "TestGoal" are actually from built-in ROS "actionlib.msg". I made the change and everything pass.

I totally understand this is a private fork. I tried to find the source, but the most original source I could find is "https://code.ros.org/svn/ros-pkg/stacks/executive_smach_tutorials/trunk", which I could not open. I was thinking all the rest were forks and some of them had no activity for few years. Then I made this issue for discussion on a most recent updated fork, looking for a fast response.

I might be wrong in somewhere, and any comment is welcome.

@LongfeiProjects
Copy link
Author

@130s Is there anything I should do to gracefully relocate/migrate the issue to "ros/common_tutorials"? Or should I wait the comment/confirmation of the issue from other experts first?

@130s
Copy link

130s commented May 16, 2018

@LongfeiProjects I'm not yet sure if ros/common_tutorials#19 gets merged. If not, though, I'll open another PR to somewhere appropriate and close to ROS core pkgs.

For now, you can open a PR against my fork, which I use for ros/common_tutorials#19.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants