Skip to content

fix: some attachments have invalid filenames, and duplicated attachment names overwrite eachother#7

Open
caesay wants to merge 1 commit intoricksbrown:masterfrom
caesay:fix-invalid-filenames
Open

fix: some attachments have invalid filenames, and duplicated attachment names overwrite eachother#7
caesay wants to merge 1 commit intoricksbrown:masterfrom
caesay:fix-invalid-filenames

Conversation

@caesay
Copy link

@caesay caesay commented Apr 2, 2025

Closes #2

Per title. There were two bugs here:

  • When attachments have invalid filenames they can not be written to disk and this stops the whole process
  • When attachments from different emails have the same filename, they get overwritten in the output folder.
    • Now we check if the filename already exists, and if it does we write it to a new file with _1, _2, etc appended to the filename.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error: ENOENT: no such file or directory

1 participant