refactor: migrate to parameterized Dockerfile with centralized config#40
Merged
refactor: migrate to parameterized Dockerfile with centralized config#40
Conversation
- Replace 4 separate Dockerfiles with single parameterized Dockerfile
- Use ghcr.io/ringcentral-docker/node as base image
- Add versions/versions.json as single source of truth (12 combinations)
- Create modular installation scripts with multi-arch support (amd64/arm64)
- Update CI/CD workflow with dynamic matrix from versions.json
- Support multi-platform builds (linux/amd64, linux/arm64)
Breaking changes:
- Base image changed from node:alpine to ringcentral/node (Ubuntu-based)
- Image tags updated to new format: node{major}-jdk{version}
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking changes: