Avoid lodash

[ledamint]

No description provided.

[DmitryKorlas]

a good section, i like it. my common feedback - please add few words regarding to polyfills. Otherwise it looks unsafely to swapping to native methods.

[DmitryKorlas]

one more - is adding a few words when lodash is preferred, say reduce an Object, or find via object, is a shorthand's we prefer.

_.reduce({foo: 'FOO', bar: 'BAR'}, callback, {});
_.find( [{baz: 10}, {baz: 30}, {baz: 50}], {foo: 30});

[ledamint]

Maybe we will leave only bad cases to not divide all lodash functionality to good or bad? I described popular and often used methods. In cases above, we can use Object.(keys|values|entries) and after use array methods.

[DmitryKorlas]

I guess we have to provide a list of all bad technics we have to replace to native alternatives. Regarding to using two methods vs one: using two methods vs one is not a good choice. We have to make our code simple and do not introduce extra boilerplate code. Lodash is created for this.

[ledamint]

It's a rare case where you need reduce to object and I think it's nice to directly show where is a plain array or where is an object which you need to use as an array. You use one short method with particular cases and your code remains strict, native and without external modules except using external functionality which eats any type

[DmitryKorlas]

A good section, i like it. my common feedback - please add few words regarding to polyfills and examples when lodash is preferred.

[DmitryStolbov]

Need more examples for Object, for instance:

// BAD
_.isEmpty(value)
// GOOD
!Object.keys(value).length

[DmitryKorlas]

Disagree. This one is too strict and not cross browser. I don't think we have totally forbid lodash. A lot of cases when lodash functionality is better choice vs native build-ins. I guess we have to prefer native methods when possible, but do not dictate using only native methods by introducing this rule into guide.

[ledamint]

It's not all at all. It is just which are easy to replace by native implementation https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore/blob/master/lib/rules/rules.json

[DmitryKorlas]

This one does not looks better vs lodash variant. _.uniq is more clear and shortener. Also, Set has cross browser limitations.

[ledamint]

Native and one line, easy to understand or to google purpose if not. I suggest it's a nice choice, IE should die, thinking about it is an atavism in 2k19. It will be attention about polyfills

[DmitryKorlas]

Array.prototype.includes is not a cross browser and still not supported in IE11. Native variant is only preferred when polyfill is included. Otherwise it dangerous and we should not recommend it.

[ledamint]

I will add a attention about polyfills

[DmitryKorlas]

A good note, I like it. I guess it would be better to clarify which variants is dangerous and add a link to MDN for every such method. We have to notify a users of this document.

[ledamint]

I suggest to not create a compatibility map, all developers understand about using different functionality and should think about each method itself depending which browser support is needed for an application

[DmitryKorlas]

see the feedback in a comments