Converted all emails in the Register/Login Post Request to lowercase.#20
Open
matthewesp wants to merge 1 commit intorishipr:masterfrom
Open
Converted all emails in the Register/Login Post Request to lowercase.#20matthewesp wants to merge 1 commit intorishipr:masterfrom
matthewesp wants to merge 1 commit intorishipr:masterfrom
Conversation
…ogin post request to ensure that there won't be duplicated emails in depending the the users' casing choice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solves the issue of the emails becoming duplicated in the DB.
For example:
Emails could have shown up as
Logging the email into the database multiple times as different identities. This is fixed by simply adding the toLowerCase() method before adding or checking an email in a database.