Adding option to choose default result window#139
Open
patrickwhite256 wants to merge 1 commit intorking:masterfrom
Open
Adding option to choose default result window#139patrickwhite256 wants to merge 1 commit intorking:masterfrom
patrickwhite256 wants to merge 1 commit intorking:masterfrom
Conversation
patrickwhite256
force-pushed
the
master
branch
2 times, most recently
from
0cee7a3 to
38af2e8
Compare
- Adding `g:ag_default_window_type` to choose to use the quickfix or location list - Adding `:LAg...` variants of commands that did not already have them - Adding `:QAg...` variants of all commands Previously, it was difficult to use the location list by default, since something like `command -nargs=* Ag LAg <args>` in the vimrc would get overridden by the `command!` in the plugin. In my opinion, the variants should eventually be removed, since I don't really see a reason why someone would want to use one list sometimes but the other sometimes. If people agree with me: - The `:LAg...` variants should be put on a deprecation path - The `:QAg...` variants should just be removed now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
g:ag_default_window_typeto choose to use the quickfix orlocation list
:LAg...variants of commands that did not already have them:QAg...variants of all commandsPreviously, it was difficult to use the location list by default, since
something like
command -nargs=* Ag LAg <args>in the vimrc would getoverridden by the
command!in the plugin.In my opinion, the variants should eventually be removed, since I don't
really see a reason why someone would want to use one list sometimes but
the other sometimes. If people agree with me:
:LAg...variants should be put on a deprecation path:QAg...variants should just be removed nowIf you agree they should be removed, I'll update the PR to do these things.