Skip to content

Don't use config.asset_host for GraphQL::Dashboard assets #5511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rmosolgo merged 2 commits into from
Jan 22, 2026
+11 −7
Merged

Don't use config.asset_host for GraphQL::Dashboard assets #5511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74c58f6
Don't use config.asset_host for GraphQL::Dashboard assets
rmosolgo Jan 21, 2026
179a4e1
Fix system tests now that config.asset_host is set
rmosolgo Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions lib/graphql/dashboard/views/layouts/graphql/dashboard/application.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@
<meta charset="utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1">
<title>GraphQL Dashboard <%= content_for?(:title) ? " · #{content_for(:title)}" : "" %> </title>
<%= stylesheet_link_tag graphql_dashboard.static_path("bootstrap-5.3.3.min.css") %>
<%= stylesheet_link_tag graphql_dashboard.static_path("charts.min.css") %>
<%= stylesheet_link_tag graphql_dashboard.static_path("dashboard.css") %>
<%= javascript_include_tag graphql_dashboard.static_path("bootstrap-5.3.3.min.js") %>
<%= javascript_include_tag graphql_dashboard.static_path("dashboard.js") %>
<link rel="stylesheet" href="<%= graphql_dashboard.static_path("bootstrap-5.3.3.min.css") %>" media="screen" />
<link rel="stylesheet" href="<%= graphql_dashboard.static_path("charts.min.css") %>" media="screen" />
<link rel="stylesheet" href="<%= graphql_dashboard.static_path("dashboard.css") %>" media="screen" />
<script src="<%= graphql_dashboard.static_path("bootstrap-5.3.3.min.js") %>"></script>
<script src="<%= graphql_dashboard.static_path("dashboard.js") %>"></script>
<%= csrf_meta_tags %>
</head>
<body class="h-100 d-flex flex-column">
Expand Down
4 changes: 3 additions & 1 deletion spec/dummy/app/views/layouts/application.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@
<head>
<title>Dummy</title>
<%= csrf_meta_tags %>
<%= javascript_include_tag 'application' %>
<%=
javascript_include_tag 'application', host: "" # work around config.asset_host which is set to test dashboard
%>
</head>

<body>
Expand Down
1 change: 1 addition & 0 deletions spec/dummy/config/application.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,6 @@ module Dummy
class Application < Rails::Application
# Don't generate system test files.
config.generators.system_tests = nil
config.asset_host = "http://some.cdn"
end
end
3 changes: 2 additions & 1 deletion spec/dummy/test/controllers/dashboard/landings_controller_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,10 @@
require "test_helper"

class DashboardLandingsControllerTest < ActionDispatch::IntegrationTest
def test_it_shows_a_landing_page
def test_it_shows_a_landing_page_with_local_static_asset_links
get graphql_dashboard.root_path
assert_includes response.body, "Welcome to the GraphQL-Ruby Dashboard"
assert_includes response.body, '<link rel="stylesheet" href="/dash/statics/bootstrap-5.3.3.min.css" media="screen" />', "it doesn't use config.asset_host"
end

def test_it_shows_version_and_schema_info
Expand Down
Loading