Modify build.py resolveVersions(self, files):#5
Open
MartinNicholls wants to merge 1 commit intorocksclusters:masterfrom
Open
Modify build.py resolveVersions(self, files):#5MartinNicholls wants to merge 1 commit intorocksclusters:masterfrom
MartinNicholls wants to merge 1 commit intorocksclusters:masterfrom
Conversation
from if not dict.has_key(name) or e >= dict[name]: to if not dict.has_key(name) or e.getName() >= dict[name].getName(): so that rpm release is include in comparision.
Contributor
|
I still need to look at this. This is a holdover from when version naming was highly inconsistent and this defaulted to dates. This should probably just use version information from the appropriate RPM python class. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found that "rocks create distro" did not use the latest rpm release following
rebuild of an unrelated Roll.
The resolveVersions was using the comparision operation from the File class
which uses getUniqueName() which has the package name and arch but not the release.
from if not dict.has_key(name) or e >= dict[name]:
to if not dict.has_key(name) or e.getName() >= dict[name].getName():
so that rpm release is include in comparision.
Fo