Remove spaces from role names #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrparkers
reviewed
Jul 15, 2021
| realm_id = keycloak_realm.rode_demo.id | ||
| client_id = keycloak_openid_client.rode.id | ||
| name = each.key | ||
| name = replace(each.key, " ", "") |
Contributor
There was a problem hiding this comment.
I'd probably just modify the local.roles variable instead of doing this, since it would reflect the actual strings that rode is expecting
Contributor
Author
There was a problem hiding this comment.
I left the local variable as-is since it's also used to create users and groups. We could keep have the user accounts all named after the role (PolicyAdministrator), but right now they're lower-case and hyphenated: policy-administrator.
I could go either way, but that's why I just changed the name in the role.
Contributor
There was a problem hiding this comment.
Okay, it's probably fine then
mrparkers
approved these changes
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came out of #67, as role values in Azure can't contain spaces. This PR strips spaces from the role values when configuring Keycloak, so that Rode doesn't have to transform role values or maintain a map for different providers.