Merging with the original repository#3
Open
rodrigogs wants to merge 35 commits intorodrigogs:masterfrom
Open
Conversation
- Update packages
mysql -> 2.17.1
iconv-lite -> 0.4.24
nodeunit -> 0.11.3
eslint -> 5.16.0
- clone object with Object.assign - rename variable self.binlog to self.BinlogClass - make some variables as const - extract out a method named '_establishConnection' - establish mysql connection on demand - callback of _isChecksumEnabled, _findBinlogEnd should return error instead of throwing
- Execute querySequence right after startNewZongJi - Use unary increments like `updateEvents++` in a single line
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.11 to 4.17.14. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.11...4.17.14) Signed-off-by: dependabot[bot] <support@github.com>
…e event after first step finished
- Force to use let / const to declare variables - Use arrow function to avoid passing this, like `self = this`
- Enable es2020 syntax in eslint
…he events emitted
- constructor doesn't have options as the 2nd parameter - store all the includeEvent / excludeEvent / includeSchema / excludeSchema in a new field `filters` - rename `set` to `_filters`, it will reset the filters everytime it's called
Use DataView to fix IEEE754 conversion error.
|
Hello @rodrigogs Are you planning to merge this? Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.