Remove deprecated Registrar, update example project#49
Open
berkaykurkcu wants to merge 2 commits intorodydavis:masterfrom
Open
Remove deprecated Registrar, update example project#49berkaykurkcu wants to merge 2 commits intorodydavis:masterfrom
berkaykurkcu wants to merge 2 commits intorodydavis:masterfrom
Conversation
Author
|
This PR is still relevant |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Flutter 3.32.0, any project that uses flutter_midi plugin was not compilable. These small improvements solves the issues.
Flutter has removed the V1 embedding, which includes the PluginRegistry.Registrar class.
flutter_midi package was still using for backwards compatibility. Modifying FlutterMidiPlugin.java and removing PluginRegistry.Registrar solves
error: cannot find symbol import io.flutter.plugin.common.PluginRegistry.Registrar;Example project is built with Flutter 3.32.0, and works as intended (tested on Android emulator)