Fix iOS 26 crash in AudioUnitMIDISynth soundfont load#51
Open
x-sti wants to merge 1 commit intorodydavis:masterfrom
Open
Fix iOS 26 crash in AudioUnitMIDISynth soundfont load#51x-sti wants to merge 1 commit intorodydavis:masterfrom
x-sti wants to merge 1 commit intorodydavis:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to use an SF2 soundfont, the following happens:
Unrecognized selector -[Foundation._SwiftURL baseURL]
CoreSimulator 1051.17.7 - Device: iPhone 16e (CD430125-582A-404C-AA12-E4C8BE3FFF63) - Runtime: iOS 26.2 (23C54) - DeviceType: iPhone 16e
This is happening in the following stack in the AudioUnitMIDISynth class:
AudioUnitSetProperty()
loadMIDISynthSoundFont()
prepare()
init()
The reason seems to be that Swift in iOS 26 has changed the transformation of URL to pointers. See description here: https://stackoverflow.com/questions/78371703/is-swift-5-10-warning-about-likely-incorrect-actually-incorrect-for-optional
Proposed transformation:
current code:
let status = AudioUnitSetProperty( self.midisynthUnit!, AudioUnitPropertyID(kMusicDeviceProperty_SoundBankURL), AudioUnitScope(kAudioUnitScope_Global), 0, &bankURL, UInt32(MemoryLayout.size))
new code:
withUnsafePointer(to: bankURL as CFURL) { let status = AudioUnitSetProperty( self.midisynthUnit!, AudioUnitPropertyID(kMusicDeviceProperty_SoundBankURL), AudioUnitScope(kAudioUnitScope_Global), 0, $0, UInt32(MemoryLayout.size(ofValue: bankURL)) )
Tested and works fine in Simulator with iPhone 16e.