Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I have modified:
In Student.java
Initially I thought I had to use approvedCourses to add the course information.
So, I added courses.add(course);
Also, I added if statement.
public void enrollToCourse(Course course )
{
//TODO implement this method
if(!(isAttendingCourse(course.getCode()))) {
//Initially I did correctly. I overthought add all registered courses to approvedCourses.
//Modified back again
courses.add(course);
//Used for isAttendingCourse
registerApprovedCourse(course);
}
else {
System.out.println("The student has been enrolled");
}
}
In StudentServices.java
I created a method to be able to print the courses, but reflected the duplicate courses.
public void addEnrollStudents(String studentId, Course course) {
if ( (enrolledStudents.containsKey( studentId ) ))
{
ArrayList courseList = enrolledStudents.get(studentId);
System.out.println("CourseList" + courseList);
//For avoiding ConcurrentModificationException,used for loop
boolean flag = false;
for(int i = 0; i < courseList.size(); i++) {
if (courseList.get(i).getCode().equals(course.getCode())) {
flag = true;
}
}
if(!(flag)) {
enrolledStudents.get(studentId).add( course );
}
}
else {
enrolledStudents.put( studentId, new ArrayList<>() );
enrolledStudents.get(studentId).add( course );
}
}