Allow using artifact registry without credentials #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| object ArtifactRegistryUrlHandlerFactory { | ||
|
|
||
| private lazy val googleCredentials = { | ||
| private def googleCredentials(logger: Logger): Option[GoogleCredentials] = { |
Contributor
Author
There was a problem hiding this comment.
No need to cache the GoogleCredentials here, it's already cached in DefaultsCredentialsProvider
rolang
approved these changes
Jan 17, 2026
Owner
rolang
left a comment
rolang
left a comment
There was a problem hiding this comment.
Thanks for your contribution @adrien-piquerez-da ! Looks good to me ✔️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to be able to resolve artifacts from a public Google Artifact Registry, which does not require any authentication.
The current implementation always tries to load the credentials or fails with an
IOException:To fix this,
googleCredentialscan catch theIOExceptionand returnNoneinstead.