[ROMM-2853] Update rom_file.category column enum

[gantoine]

Description
^{Explain the changes or enhancements you are proposing with this pull request.}

Fixes #2853

Checklist
^{Please check all that apply.}

• I've tested the changes locally
• I've updated relevant comments
• I've assigned reviewers for this PR
• I've added unit tests that cover the changes

[gemini-code-assist]

Summary of Changes

Hello @gantoine, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a database migration to enhance the categorization capabilities for ROM files. It expands the set of allowed values for the category column in the rom_files table, allowing for more granular and descriptive classification of various ROM types. This change ensures better data representation and flexibility within the system.

Highlights

• New Alembic Migration: A new Alembic migration script, 0062_rom_file_category_enum.py, has been added to manage database schema changes.
• Expanded ROM File Categories: The rom_file.category column's enum has been updated to include new categories such as 'DLC', 'HACK', 'MANUAL', 'PATCH', 'UPDATE', 'MOD', 'DEMO', 'TRANSLATION', and 'PROTOTYPE'.
• Column Nullability: The category column in the rom_files table has been modified to be nullable, providing more flexibility for entries without a specified category.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces an Alembic migration to update the rom_file.category enum. While the intent is clear, the implementation has critical flaws. The upgrade function uses uppercase enum values, which is inconsistent with the application models, and incorrectly uses alter_column. More importantly, the downgrade function is empty, making the migration irreversible, which is a significant risk. I've provided comments with suggestions to fix these issues to ensure the migration is safe and correct.

[github-actions]

Test Results

702 tests  ±0   701 ✅ ±0   1m 26s ⏱️ +3s
  1 suites ±0     1 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit dbc9af3. ± Comparison against base commit 6b600dd.

♻️ This comment has been updated with latest results.

[github-actions]

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines	Covered	Coverage	Threshold	Status
12120	7885	65%	0%	🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: dbc9af3 by action🐍