[HOTFIX] Set metadata fields as nullable

[gantoine]

Description
^{Explain the changes or enhancements you are proposing with this pull request.}

If a user accidentally sets a value in the metadata JSON to null via the UI, pydantic will crash and they won't be able to fix it.

Checklist
^{Please check all that apply.}

• I've tested the changes locally
• I've updated relevant comments
• I've assigned reviewers for this PR
• I've added unit tests that cover the changes

[gemini-code-assist]

Summary of Changes

Hello @gantoine, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This hotfix addresses an issue where setting metadata fields to null via the UI would cause Pydantic validation errors and application crashes. The changes involve updating both backend Python TypedDict and frontend TypeScript type definitions to explicitly mark specific string fields as nullable, thereby improving the robustness and user experience when handling metadata.

Highlights

• Backend Type Definitions: Updated Python TypedDict definitions for FlashpointMetadata, IGDBMetadata, MobyMetadata, and SSMetadata to allow None for certain string fields, preventing Pydantic validation errors when null values are received.
• Frontend Type Definitions: Modified TypeScript type definitions for RomFlashpointMetadata, RomIGDBMetadata, RomMobyMetadata, and RomSSMetadata to explicitly allow null for corresponding string fields, ensuring consistency with backend changes and preventing potential type mismatches.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly addresses a crash in the UI by making several metadata fields nullable. The changes are applied consistently across the Python backend TypedDict models and the auto-generated TypeScript frontend models.

I've identified a few areas for improvement in the data extraction logic within the metadata handlers. Currently, some handlers produce empty strings ("") or even the literal string "None" for missing data, which is inconsistent with the new nullable types. More critically, the IGDB handler has a potential TypeError that could lead to a crash if the API returns null for a rating. I've left specific comments on the relevant files with suggestions to make the extraction logic more robust and consistent.

While these suggestions might be out of scope for this hotfix, addressing the potential crash in the IGDB handler should be considered with higher priority.

[github-actions]

Test Results

702 tests  ±0   701 ✅ ±0   1m 27s ⏱️ +2s
  1 suites ±0     1 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 1610bf2. ± Comparison against base commit 1019274.

[github-actions]

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines	Covered	Coverage	Threshold	Status
12120	7885	65%	0%	🟢

New Files

No new covered files...

Modified Files

File	Coverage	Status
backend/handler/metadata/flashpoint_handler.py	46%	🟢
backend/handler/metadata/igdb_handler.py	36%	🟢
backend/handler/metadata/moby_handler.py	38%	🟢
backend/handler/metadata/ss_handler.py	32%	🟢
TOTAL	38%	🟢

updated for commit: 1610bf2 by action🐍