This repository was archived by the owner on Dec 28, 2019. It is now read-only.
Remove NetBeans project files in favor of gradle files + updated docker#488
Open
kolakcc wants to merge 1 commit intoronancpl:masterfrom
Open
Remove NetBeans project files in favor of gradle files + updated docker#488kolakcc wants to merge 1 commit intoronancpl:masterfrom
kolakcc wants to merge 1 commit intoronancpl:masterfrom
Conversation
xinyifly
reviewed
Jul 15, 2019
| RUN sh ./posix-compile.sh | ||
| ADD wz ./wz | ||
| ADD docker-launch.sh configuration.ini world.ini ./ | ||
| ADD build/libs/HeavenMS.jar HeavenMS.jar |
There was a problem hiding this comment.
This will break the build from a clean clone: build/libs/HeavenMS.jar: no such file or directory
(Maybe you forgot to include ./gradlew build in a multi-stage build?)
Contributor
Author
There was a problem hiding this comment.
./gradlew build shouldn't be included in the image, as it will increase the image size and never cause containers to cache due to non-deterministic gradle builds and cache files. The project should be built out of docker for this reason.
Contributor
Author
|
I've clarified the instructions, using a29c3bc as a base.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.jarfiles in favor of dependency managed libaries from Maven.gradlew build.gradlew run.docker-compose, which will boot a mysql server as well as the server.