Improved omitempty tag and added support for omitnil#29
Merged
OrCh3n merged 1 commit intoroneli:mainfrom Apr 20, 2025
Merged
Conversation
OrCh3n
approved these changes
Apr 20, 2025
| if dbTag := f.Tag.Get(tagNameDb); dbTag != "" { | ||
| if strings.Contains(dbTag, omitEmpty) { | ||
| if value.IsZero() { | ||
| if !value.IsValid() || value.IsZero() { // IsZero panic on valid values |
Collaborator
There was a problem hiding this comment.
since when does it panic? Is it related to the nil pointer dan made?
Contributor
Author
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for the
omitniltag for cases where we want to skip insert/update of nil fields