Color contrast and other a11y changes #278
Open
+24
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge master to staging
Merge dev to staging: Bump sha.js from 2.4.11 to 2.4.12
Merge staging into master: Bump sha.js from 2.4.11 to 2.4.12
Merge dev into staging with copy button added
Merge staging into master with copy button added
jrhoads
reviewed
Jan 5, 2026
| <div> | ||
| <h2>Subscribe to the ROR newsletter</h2> | ||
| <a target="_blank" class="btn btn-sm btn-round red" rel="noopener" href="http://eepurl.com/gjkT9H">Subscribe</a> | ||
| <a target="_blank" class="btn btn-sm btn-round raspberry" rel="noopener" href="http://eepurl.com/gjkT9H">Subscribe</a> |
Member
There was a problem hiding this comment.
I'll need to test locally but I'm not sure that raspberry is getting applied. I see that it was added as a color but not necessarily as a css class.
Contributor
Author
There was a problem hiding this comment.
I added raspberry as a color variable in /app/styles/app.scss, and when I tested locally it did work -- but yes, please do additional testing! Note that the styles for ror-app and ror-site are intertwingled somehow in a way I've never fully understood, so it could have worked on my machine because I had the ROR site running locally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes address ror-community/ror-roadmap#335 and are to be accompanied by equivalent changes on the ROR website that are ready to be deployed in branch "palette". Compliance tested by WAVE WEBAIM tool browser extension.
Note that I wasn't able to resolve the "empty button" error that apparently applies to the responsive nav hamburger.