“Configuration/Movement/Safety-critical" interfaces definition#51
Open
destogl wants to merge 2 commits intoros-controls:masterfrom
Open
“Configuration/Movement/Safety-critical" interfaces definition#51destogl wants to merge 2 commits intoros-controls:masterfrom
destogl wants to merge 2 commits intoros-controls:masterfrom
Conversation
|
I suggest to be careful labelling something as safety-critical or suitable for safety critical situations. It implies quite a few things, and I don't believe |
Member
|
A little off-topic but relevant here: Is there any documentation about the lifecycle implementation within ros2_control which I couldn't find? Up to now it was not clear to me that read/write methods of the hardware components are called in inactive state, too. I understand now the motivation here, but I'm not sure if this really solves the problem for every hardware architecture (but honestly, I do not have a lot of experience with industrial robots with ROS):
|
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #50
Please add your comments as review.