Migrate std::bind calls to lambda expressions#76
Merged
Conversation
ahcorde
approved these changes
Jan 8, 2024
clalancette
requested changes
Jan 8, 2024
Contributor
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
Two changes to pass linters, then this is probably good to go.
Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Co-authored-by: Chris Lalancette <clalancette@gmail.com>
clalancette
requested changes
Jan 8, 2024
Contributor
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
One more linter error (not sure why this didn't show up in the earlier run).
ahcorde
requested changes
Jan 9, 2024
Contributor
ahcorde
left a comment
ahcorde
left a comment
There was a problem hiding this comment.
2024-01-08T15:02:27.9197222Z 7: --- src/turtle_tf2_listener.cpp
2024-01-08T15:02:27.9197566Z 7: +++ src/turtle_tf2_listener.cpp.uncrustify
2024-01-08T15:02:27.9197935Z 7: @@ -56 +56 @@
2024-01-08T15:02:27.9198266Z 7: - 1s, [this](){return this->on_timer();});
2024-01-08T15:02:27.9198687Z 7: + 1s, [this]() {return this->on_timer();});Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Contributor
Author
|
I executed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a follow up to the changes made in the documentation ros2/ros2_documentation#4041
The migration of std::bind calls made in the docs is reflected here