Skip to content

Conversation

@emersonknapp
Copy link
Contributor

Description

Working on a "completeness" pass for the launch frontends. These Actions were trivial to expose but hadn't been. That should cover everything that doesn't involve Events or "Opaque" processes.

Is this user-facing behavior change?

New feature

Did you use Generative AI?

no

Additional Information

N/A

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
@christophebedard
Copy link
Member

Would you mind adding some simple tests?

Copy link
Contributor

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implementation looks good, test would be ideal.

Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emersonknapp do you have plans to add some tests here ?

@SuperJappie08
Copy link

SuperJappie08 commented Feb 10, 2026

@emersonknapp, Is it wise to expose Pop and Push actions?
As they are internally used to handle the scoping in Actions such as GroupAction, I assumed they were ment to be internal (back-end) actions.

My fear stems from the case where a user were to push and pop these incorrectly.
This could result in breaking these other 'scoping' actions cause trouble down the line.
An example would be pushing and not popping (while in a group).

Does exposing those, what I assumed to be internal, scope setting Actions to the user add to the usefulness in the front-end.
As the scoping can already be achieved by using the GroupAction.

EDIT: Phrasing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants