Replace deprecated spin_until_future_complete with spin_until_complete#306
Replace deprecated spin_until_future_complete with spin_until_complete#306hliberacki wants to merge 2 commits intoros2:rollingfrom
Conversation
|
Due to change in RCLCPP - ros2/rclcpp#1874 Pull request |
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
Can we avoid unnecessary changes to re-format?
|
@fujitatomoya i will restore all formating base changes, they were due to some formatting plugin in IDE which did it implicitly (i did not check the diff good enough). it was not my intention |
jacobperron
left a comment
jacobperron
left a comment
There was a problem hiding this comment.
For context, this connects to ros2/rclpy#919
Signed-off-by: Hubert Liberacki <hliberacki@gmail.com>
hliberacki
force-pushed
the
hliberacki/spin_until
branch
from
89c87b8 to
d65ad3e
Compare
|
@ros-pull-request-builder retest this please |
Unfortunately, this CI will most probably fail. This is because it did not include all the related PRs and there will be a missing include issue. Here is a CI run for all my changes in each connected PRs. |
|
@hliberacki thanks for the heads up. Indeed, CI will fail w/o ros2/rclpy#919. |
|
Since this is part of rclpy changes, it's blocked on ros2/rclpy#919 (review), but is not needed to fix CI after ros2/rclcpp#1874 was merged prematurely. |
|
I've opened #396 to replace this PR. |
|
This can be closed, see #396 (comment) |
8 participants
Signed-off-by: Hubert Liberacki hliberacki@gmail.com