Skip to content

Add --namespace argument to launch command.#433

Open
StefanFabian wants to merge 2 commits intoros2:rollingfrom
StefanFabian:rolling
Open

Add --namespace argument to launch command.#433
StefanFabian wants to merge 2 commits intoros2:rollingfrom
StefanFabian:rolling

Conversation

@StefanFabian
Copy link

@StefanFabian StefanFabian commented Jan 23, 2025 •
edited
Loading

This PR adds support for pushing a namespace when launching a launch file.

fujitatomoya
fujitatomoya approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, i would add the test but i do not see any tests for ros2 launch...

@Yadunund
Copy link
Member

Yadunund commented Feb 6, 2025

@StefanFabian could you please follow up with adding tests?

@audrow
Copy link
Member

audrow commented Feb 20, 2025

@StefanFabian, friendly ping

@StefanFabian
Copy link
Author

StefanFabian commented Feb 21, 2025

I'm sorry, but we are preparing for a robotics competition in the second week of March, and I don't have any time to invest here until after the competition.

@kramer-sim kramer-sim force-pushed the rolling branch 2 times, most recently from d3b1ca1 to 0ea4d94 Compare March 25, 2025 10:45
@StefanFabian StefanFabian force-pushed the rolling branch 2 times, most recently from 0e09968 to 35a832b Compare March 25, 2025 11:49
@StefanFabian
Copy link
Author

StefanFabian commented Mar 31, 2025

@kramer-sim was nice enough to add a test case. Does this work for you? @Yadunund @audrow

@sloretz
Copy link
Contributor

sloretz commented Apr 10, 2025

@Mergifyio rebase

StefanFabian and others added 2 commits April 10, 2025 23:42
@StefanFabian @sloretz
Add --namespace argument to launch command to push a namespace when l…
587b244 
…aunching a launch file.

Signed-off-by: Stefan Fabian <fabian@sim.tu-darmstadt.de>
Signed-off-by: Markus Kramer <kramer@sim.tu-darmstadt.de>
@kramer-sim @sloretz
added testcase for namespace
f43715d 
Signed-off-by: Markus Kramer <kramer@sim.tu-darmstadt.de>
@mergify
Copy link

mergify bot commented Apr 10, 2025

rebase

✅ Branch has been successfully rebased

@sloretz
Copy link
Contributor

sloretz commented Apr 10, 2025

Pulls: #433
Gist: https://gist.githubusercontent.com/sloretz/8be04560d0b910c8a58ac76bb18fd39d/raw/1a7f19b1d3377a26994852f32a426d1136185a8d/ros2.repos
BUILD args:
TEST args:
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15660

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

fujitatomoya
fujitatomoya requested changes Apr 11, 2025
View reviewed changes
Copy link
Contributor

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing, could you address the failures?

launch_ros/test/test_cli_namespace.py


if __name__ == '__main__':
unittest.main() No newline at end of file
Copy link
Contributor

@fujitatomoya fujitatomoya Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing last line feed detected by github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fujitatomoya fujitatomoya fujitatomoya requested changes

Assignees

@fujitatomoya fujitatomoya

Labels

more information needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@StefanFabian @Yadunund @audrow @sloretz @fujitatomoya @kramer-sim