Skip to content

Re-enable executor test on rmw_connextdds. (backport #2693)#2695

Merged
fujitatomoya merged 1 commit intojazzyfrom
mergify/bp/jazzy/pr-2693
Dec 4, 2024
Merged

Re-enable executor test on rmw_connextdds. (backport #2693)#2695
fujitatomoya merged 1 commit intojazzyfrom
mergify/bp/jazzy/pr-2693

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Dec 3, 2024

It supports the events executor now, so re-enable the test.

This is follow-up to #2683 . @jmachowinski @fujitatomoya FYI

This is an automatic backport of pull request #2693 done by Mergify.

@clalancette @mergify
Re-enable executor test on rmw_connextdds. (#2693)
e6d1126 
It supports the events executor now, so re-enable the test.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit d724536)
@mergify mergify bot mentioned this pull request Dec 3, 2024
Merged
@fujitatomoya
Copy link
Collaborator

fujitatomoya commented Dec 3, 2024

Pulls: #2695
Gist: https://gist.githubusercontent.com/fujitatomoya/9e5ffad8006f2d0bdb8f55e5e825895b/raw/0a570d78231b0ee961099bfdfcbd4087343dac8c/ros2.repos
BUILD args: --packages-above-and-dependencies rclcpp
TEST args: --packages-above rclcpp
ROS Distro: jazzy
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14901

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Collaborator

fujitatomoya commented Dec 3, 2024

retry windows

  • Windows Build Status

@fujitatomoya
Copy link
Collaborator

fujitatomoya commented Dec 3, 2024

@clalancette @alsora just want to confirm my understanding is correct. Listener API is supported with ros2/rmw_connextdds#76, and that was available from jazzy. besides, CI is green, are we good to merge this?

@clalancette
Copy link
Contributor

clalancette commented Dec 4, 2024

@clalancette @alsora just want to confirm my understanding is correct. Listener API is supported with ros2/rmw_connextdds#76, and that was available from jazzy. besides, CI is green, are we good to merge this?

Yeah, I think with green CI we are good to go with this. I'll approve.

@fujitatomoya fujitatomoya merged commit 74162b1 into jazzy Dec 4, 2024
@MichaelOrlov MichaelOrlov deleted the mergify/bp/jazzy/pr-2693 branch July 29, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clalancette clalancette clalancette approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fujitatomoya @clalancette