Merged
Conversation
Signed-off-by: Barry Xu <barry.xu@sony.com>
ahcorde
requested changes
Mar 3, 2025
Signed-off-by: Barry Xu <barry.xu@sony.com>
Collaborator
Author
Contributor
|
Pulls: #2759
|
Collaborator
|
@ahcorde thanks for reviewing and running CI. @Barry-Xu-2018 windows test build failed, can you take a look? |
fujitatomoya
approved these changes
Mar 6, 2025
Collaborator
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
lgtm, just one thing i would like to confirm.
Signed-off-by: Barry Xu <barry.xu@sony.com>
Collaborator
Author
I fixed it by 3f155e8. |
Contributor
|
Collaborator
|
@ahcorde thanks for running CI. all your comments are addressed, could you approve? |
ahcorde
approved these changes
Mar 7, 2025
kshinjo-pfr
pushed a commit
to kshinjo-pfr/rclcpp
that referenced
this pull request
Jan 13, 2026
kshinjo-pfr
pushed a commit
to kshinjo-pfr/rclcpp
that referenced
this pull request
Jan 13, 2026
Backport from rolling to jazzy. This adds GenericClient for rclcpp_action, which allows creating action clients without compile-time knowledge of the action type. New files added: - generic_client.hpp/cpp - generic_client_goal_handle.hpp/cpp - create_generic_client.hpp/cpp - client_base.hpp (wrapper for jazzy compatibility) - test_generic_client.cpp Note: On jazzy, ClientBase remains in client.hpp (not separated). client_base.hpp is a compatibility wrapper that includes client.hpp. Original PR: ros2#2759 Signed-off-by: Barry Xu <barry.xu@sony.com>
ahcorde
pushed a commit
that referenced
this pull request
Feb 13, 2026
* Implement action generic client (#2759) Backport from rolling to jazzy. This adds GenericClient for rclcpp_action, which allows creating action clients without compile-time knowledge of the action type. New files added: - generic_client.hpp/cpp - generic_client_goal_handle.hpp/cpp - create_generic_client.hpp/cpp - client_base.hpp (wrapper for jazzy compatibility) - test_generic_client.cpp Note: On jazzy, ClientBase remains in client.hpp (not separated). client_base.hpp is a compatibility wrapper that includes client.hpp. Original PR: #2759 Signed-off-by: Barry Xu <barry.xu@sony.com> * Fix jazzy compatibility for generic action client Add local implementation of get_action_typesupport_handle() which is not available in jazzy's rclcpp (only in rolling). Signed-off-by: Koki Shinjo <kshinjo@pfrobotics.jp> * Remove client_base.hpp and use client.hpp directly in generic_client.hpp As per review feedback, there is no need to create a separate client_base.hpp since including client.hpp directly serves the same purpose. Signed-off-by: Koki Shinjo <kshinjo@pfrobotics.jp> Signed-off-by: Barry Xu <barry.xu@sony.com> Signed-off-by: Koki Shinjo <kshinjo@pfrobotics.jp> Co-authored-by: Barry Xu <barry.xu@sony.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address ros-infrastructure/rep#405
Action GenericClient will be used in rosbag2 to support actions.