Update docs for configuring logging formats (espcially for use with ros2 launch)#4061
Draft
SammyRamone wants to merge 4 commits intoros2:rollingfrom
Draft
Update docs for configuring logging formats (espcially for use with ros2 launch)#4061SammyRamone wants to merge 4 commits intoros2:rollingfrom
SammyRamone wants to merge 4 commits intoros2:rollingfrom
Conversation
Signed-off-by: Marc Bestmann <marc.bestmann@dlr.de>
This was referenced Dec 12, 2023
Signed-off-by: Marc Bestmann <marc.bestmann@dlr.de>
Collaborator
|
@SammyRamone thanks for the contribution, i will take a look at the related PRs. |
fujitatomoya
reviewed
Feb 6, 2024
Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Signed-off-by: Marc Bestmann <marc.bestmann@posteo.de>
Signed-off-by: Marc Bestmann <marc.bestmann@dlr.de>
Collaborator
|
@SammyRamone does this still need to be a draft? |
Author
@fujitatomoya One of the linked PRs is not merged yet. Therefore, I don't want to merge the documentation yet. |
Author
|
This PR is still waiting for ros2/launch#713 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is PR adds additional documentation about configuring logging with ros2 launch.
It is currently a draft as it will (amon other things) provide documentation for the following PRs which are at time of writing not merged yet.
ros2/launch#713
ros2/launch#722
ros2/rcutils#443
I moved the part about escape characters from the demo section to the main logging documentation, since I think this makes more sense to keep it in one place.